[Core] Change MasterSlaveConstraint::Pointer from shared_ptr to intrusive_ptr #12896
+37
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
requested review from
RiccardoRossi,
pooyan-dadvand,
rubenzorrilla and
roigcarlo
|
Let's hope the best |
|
|
@loumalouomega at least I fixed the core ones, lets see what the applications say.. 🤞 |
|
For the moment some tests are failing in the core and it looks like a memory issue. Once tests pass I would recommend to run Valgrind as well to ensure it is clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
As in the title.
🆕 Changelog
MasterSlaveConstraint::Pointerto beintrusive_ptr